#30577: Add Fundraising Banner with next TBB security update -------------------------------------------+------------------------------- Reporter: pili | Owner: tbb-team Type: task | Status: | needs_revision Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: ux-team, TorBrowserTeam201907 | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------------+------------------------------- Changes (by gk):
* keywords: ux-team, TorBrowserTeam201907R => ux-team, TorBrowserTeam201907 * status: needs_review => needs_revision Comment: Some comments: I am a bit wary using `extensions.torbutton.donation_banner_countdown` as we had this one already in our last year-end-campaign and some users might still have this pref set to `0` in their profile. I guess we can use `extensions.torbutton.donation_banner_countdown3` instead? Nit: `// Show the Sign Up for Tor News banner a finite number of times.` no Tor News here but the donation banner. Re the language strings: The usual flow is defining the necessary ones for `en-US` and commit that and then the translations get done/added once they are ready. Thus, creating proper entries in `aboutTor.dtd` seems to be the way forward. I guess that could mean two entries for the two sentences, like `aboutTor.donationBanner3.line1` and `aboutTor.donationBanner3.line2`, given that we only want to make the second one a link? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30577#comment:14> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs