#30310: Snowflake localization -------------------------------------------------+------------------------- Reporter: cohosh | Owner: arlolra Type: task | Status: | needs_review Priority: Medium | Milestone: Component: Circumvention/Snowflake | Version: Severity: Normal | Resolution: Keywords: l10n, snowflake-webextension, anti- | Actual Points: censorship-roadmap-august | Parent ID: | Points: Reviewer: | Sponsor: | Sponsor28-can -------------------------------------------------+-------------------------
Comment (by arlolra): Here's a rebased patch that tries to address all the feedback here, https://github.com/keroserene/snowflake/commit/ecadbe3d869ae3dcdde02d24b6246859621bd34a > It may be worth doing the HTML replacement recursively on every element, to reduce coupling between popup.html and popup.js. Done > An alternative is to rephrase the UI so it's less dependent on grammar: "Number of users helped: 1". Took this route with a bit of the suggestions in #31109 > Do you think you can add proxy/webext/_locales/en/messages.json to https://gitweb.torproject.org/pluggable-transports/snowflake.git/ ? It'll be in there when this patch merges. > Also, could the language code be en-US, as it is on the rest of Tor Browser? So we keep consistency. I made it `en_US` (the difference being the underscore) because of the requirement at, https://developer.mozilla.org/en-US/docs/Mozilla/Add- ons/WebExtensions/Internationalization#Providing_localized_strings_in__locales Note the message resolution algorithm at, https://developer.mozilla.org/en-US/docs/Mozilla/Add- ons/WebExtensions/Internationalization#Retrieving_message_strings_from_JavaScript > PS: No need to add the French translation, I will import it on transifex and it may create merge conflicts. They are now removed ... mainly just used for testing. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30310#comment:14> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs