#31240: Make confparse able to handle multiple config_format_t objects at once -----------------------------------------+--------------------------------- Reporter: nickm | Owner: nickm Type: enhancement | Status: needs_revision Priority: Medium | Milestone: Tor: | 0.4.2.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: network-team-roadmap-august | Actual Points: 3 Parent ID: #29211 | Points: 3 Reviewer: teor | Sponsor: Sponsor31-can -----------------------------------------+--------------------------------- Changes (by teor):
* status: needs_review => needs_revision Comment: This commit message typo blocks merging this branch: https://github.com/nmathewson/tor/pull/3#discussion_r317549159 {{{ commit 94bfbf7859 Author: Nick Mathewson <ni...@torproject.org> Date: Tue Jul 23 10:41:57 2019 -0400 Use special magic to enforce manager/object connection. Every time we finalize a config manager, we now generate a new magic number for it, so that we'll get an assertion failure if we ever two to use an object with a different configuration manager than the one that generated it. }}} I have tried to guess the commits that fix these issues, but I'd like you to confirm on the PR: Please add runtime magic generation uniqueness tests: https://github.com/nmathewson/tor/pull/3#discussion_r317550341 Please add subconfig tests: https://github.com/nmathewson/tor/pull/3#discussion_r317552964 Do we need unit tests that have non-managed fields? https://github.com/nmathewson/tor/pull/3#discussion_r317553659 There aren't any tests that use a clear callback. Please add some. https://github.com/nmathewson/tor/pull/3#discussion_r317554429 This CI build hung: https://ci.appveyor.com/project/nmathewson/tor/builds/26996434 Let's check both torproject and nmathewson CI again after the fixes listed above. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31240#comment:12> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs