#31675: Split microdescs_parse_from_string() into smaller functions
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: task | Status: needs_revision
Priority: Low | Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 042-can | Actual Points: .3
Parent ID: | Points: 0
Reviewer: ahf | Sponsor: Sponsor31-can
--------------------------+------------------------------------
Changes (by ahf):
* status: needs_review => needs_revision
Comment:
I get an error when logging into GH right now, so the review comes inline
here:
I can see most of these things comes from code movement, but I think we
can clean them up in follow up patches while this refactoring is
happening:
On line 133 in `microdesc_parse.c`: There is a typo in the comment: witll
should be will.
On line 143 in `microdesc_parse.c`: Minor detail, but `copy_body` could
become a bool here.
On line 147 in `microdesc_parse.c`: `no_onion_key` can be promoted to a
bool.
On line 319 in `microdesc_parse.c`: `body_not_found` can also be turned
into a bool.
Otherwise I think the refactoring looks good.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31675#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
