#31759: Make "annotate_ifdef_directives" script comply with line-width limits --------------------------+------------------------------------ Reporter: nickm | Owner: nickm Type: defect | Status: needs_review Priority: Medium | Milestone: Tor: 0.4.2.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: 042-should | Actual Points: .1 Parent ID: #31713 | Points: Reviewer: catalyst | Sponsor: Sponsor31-can --------------------------+------------------------------------
Comment (by catalyst): Replying to [comment:2 nickm]: > Branch at `ticket31759`; also fixes #31779. PR at https://github.com/torproject/tor/pull/1339 ; this can become needs_review once CI has passed. Thanks! This mostly looks good by inspection. I manually ran the script and verified that it produces the claimed result in the `make autostyle` commit. I did make a comment on the pull request about how our stated (and enforced) limit seems to be 79 characters. Which one is correct? (I would say that 79 characters is better than 80, because of diff line prefixes, etc.) (Also there seem to be multiple problems with running the `make` targets for various maintainer scripts from a separate build directory, but I should probably open new ticket(s) for that.) -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31759#comment:9> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs