#31286: Include bridge configuration into about:preferences -------------------------------------------------+------------------------- Reporter: gk | Owner: | pospeselr Type: task | Status: | needs_review Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-9.0-must-alpha, | Actual Points: TorBrowserTeam201909R, ff68-esr | Parent ID: #10760 | Points: 15 Reviewer: | Sponsor: | Sponsor44-can -------------------------------------------------+------------------------- Changes (by pospeselr):
* keywords: tbb-9.0-must-alpha, TorBrowserTeam201909, ff68-esr => tbb-9.0 -must-alpha, TorBrowserTeam201909R, ff68-esr * status: assigned => needs_review Comment: Ok, this work is about 98% of the way there so here's a review branch for your perusal: tor-browser: https://gitweb.torproject.org/user/richard/tor- browser.git/commit/?h=bug_31286_review This branch is 'feature complete' in the sense that there are probably bugs lurking and there is still a bit of polish to be done, but the bulk of the code is there. The remaining work is as follows: - Pulling in strings from tor-button's dtd rather than hardcoding english - Designing and implementing a way to get the tor daemon's logs - Build a smarter way of sending SETCONF commands rather than hammering tor everytime the UI is interacted with - Remove Firefox's network settings from the General preferences - Update LearnMore links to point to real help URLs (currently pointing to example.com) - Misc refactor/code cleanup/TODOs Odds are if you see something squirrely there should be a TODO in the comments nearby but if not let me know and I'll add it to my list of work. Almost the entire patch is new code, apart from includes in the existing preferences XUL and code. Hopefully it's organized well enough for easy review. I did refactor SecurityLevel a bit, moving the strings out to a separate shared component used by both SecurityLevel and the TorNetworkSettings components (and other future integrations). Though in the future TorStrings can probably be pared down a lot as the reason it existed to begin with was because XUL falls over ungracefully if it references localization files that don't exist (as could happen with local Linux builds prior to the tor-button integration). I will try and get Linux and macOS nightlies out for this ASAP so you all can have a look at it. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31286#comment:23> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs