#31286: Include bridge configuration into about:preferences -------------------------------------------------+------------------------- Reporter: gk | Owner: | pospeselr Type: task | Status: | needs_review Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-9.0-must-alpha, ff68-esr, ux- | Actual Points: team, TorBrowserTeam201910R | Parent ID: #10760 | Points: 15 Reviewer: | Sponsor: | Sponsor44-can -------------------------------------------------+-------------------------
Comment (by gk): Awesome work! The changes in `bug_31286_review3` look reasonable to me. They still need a closer look, but I think we can use what we have for the alpha release. I merged `bug_31286_review3` to `tor-browser-68.1.0esr-9.0-2ยด (commit bd4082f2f1db8a1f1c135d6d1689242f7c659a19). Some nits: 1) You now have a `"strict;";` in your `BridgeDB.jsm`. (I fixed this in a fixup commit (109c1defa853ec6364c66a72b3554ea05304dd3f)) 2) You now have {{{ // console.log(`${setting} : ${value}`); }}} in `TorProtocolService.jsm`. If we don't want to log don't comment the code just delete it. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31286#comment:35> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs