#31992: Remove apktool workaround in #31564 -------------------------------------------+-------------------------- Reporter: gk | Owner: sisbell Type: defect | Status: assigned Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-rbm, TorBrowserTeam201911 | Actual Points: Parent ID: | Points: 0.25 Reviewer: | Sponsor: -------------------------------------------+--------------------------
Comment (by sisbell): As outlined in the original issue, the following resource(s) cause aapt to fail {{{ W: res/drawable-v21/$avd_hide_password__0.xml: Invalid file name: must contain only [a-z0-9_.] W: res/drawable-v21/$avd_hide_password__1.xml: Invalid file name: must contain only [a-z0-9_.] W: res/drawable-v21/$avd_hide_password__2.xml: Invalid file name: must contain only [a-z0-9_.] W: res/drawable-v21/$avd_show_password__0.xml: Invalid file name: must contain only [a-z0-9_.] W: res/drawable-v21/$avd_show_password__1.xml: Invalid file name: must contain only [a-z0-9_.] W: res/drawable-v21/$avd_show_password__2.xml: Invalid file name: must contain only [a-z0-9_.] }}} So after running the debugger, I could see everything was fine until the process execution of aapt. After digging through source code in various repos, I found the following commit for the custom aapt that iBotPeaches is including in the apktool. This patch ignores illegal characters in resource file names. https://github.com/iBotPeaches/platform_frameworks_base/commit/672206c5229c259e174b0a8d6d2bfdeeb753149c So there is no way the aapt packaged in Debian (regardless of version) is going to work without this patch. This is not a bug in the Debian version as aapt should reject resources. Unless we are planning on removing apktool completely and trying another approach, we can close this issue. ---------------- For reference these resources are coming from a google support library https://developer.android.com/reference/android/support/design/R.drawable.html#avd_show_password https://android.googlesource.com/platform/frameworks/support/+/support- library-27.0.2/design/res/drawable-v21/ -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31992#comment:18> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs