#31531: Make control_event_conf_changed() take a smartlist of config_line_t -------------------------------------------------+------------------------- Reporter: teor | Owner: neel Type: defect | Status: | merge_ready Priority: Medium | Milestone: Tor: | 0.4.3.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: technical-debt, extra-review- | Actual Points: 0.1 completed | Parent ID: | Points: 0.5 Reviewer: catalyst, teor | Sponsor: | Sponsor31-can -------------------------------------------------+------------------------- Changes (by teor):
* keywords: technical-debt, extra-review => technical-debt, extra-review- completed * reviewer: catalyst => catalyst, teor * actualpoints: => 0.1 Comment: I found a few issues with this patch: * the function comment for control_event_conf_changed() was not updated * the "elements" argument name is now confusing * the extra include in control_events.h could be replaced with a struct forward declaration I also found a few issues in control_event_conf_changed() unrelated to this patch: * the function comment has not been maintained, even before this PR * the return value is always the same, and it is not checked by the caller I fixed these issues in this PR: * master: https://github.com/torproject/tor/pull/1574 These are all obviously correct minor changes, so any merger can merge after it passes CI. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31531#comment:12> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs