#32021: hs-v3: Handle rendezvous client circuit build expire properly
---------------------------------------------+-----------------------------
Reporter: dgoulet | Owner: dgoulet
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, tor-client, tor-circuit | Actual Points:
Parent ID: #30200 | Points: 0.4
Reviewer: asn | Sponsor:
| Sponsor27-must
---------------------------------------------+-----------------------------
Changes (by asn):
* status: needs_review => needs_revision
Comment:
Replying to [comment:7 dgoulet]:
> See fixup commit. I'm open to a better function name... it is quite
verbose but it is super specific as well.
Hmm, I like the code logic but not a big fan of the function name
(especially with the lack of function doc)
Suggestion: Perhaps we dont need to expose a low-level function name like
`hs_circ_is_rend_sent_in_intro1()` to `circuituse.c`. Perhaps we can go
with a high-level function name like `hs_circ_rend_should_not_time_out()`
and explain the low-level stuff in the function itself.
In any case, please add a function doc for the function, and consider
adapting the function name if you like the idea above.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32021#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
