#32798: Compile every header by itself as part of "make check" --------------------------+------------------------------------ Reporter: teor | Owner: (none) Type: task | Status: needs_review Priority: Medium | Milestone: Tor: 0.4.3.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: | Actual Points: 1 Parent ID: #32764 | Points: 2 Reviewer: nickm, teor | Sponsor: --------------------------+------------------------------------ Changes (by teor):
* status: new => needs_review * reviewer: => nickm, teor * actualpoints: => 1 Comment: I think I have this script in a reviewable, production-ready state. It checks the header failures against an exceptions file, and only fails when a header unexpectedly fails. See my PR, based on yours: * master: https://github.com/torproject/tor/pull/1618 Here are the key changes: * Add an exceptions file, so we can make changes incrementally * Support out-of-tree builds * Look for more defines, more reliably * Check more headers * Other minor fixes * Create prefix.h for allowed prefix includes Maybe you can help with this change: * use CFLAGS etc. from the Makefile After we've finished reviews and revisions, we should: * rebase on #32764 * and run "make update-build-headers-exceptions" There's still plenty we can do to improve it: * prefix.h: * stop including torint.h and testsupport.h * integrate using an include.am file, rather than generating a Makefile? * make Makefile dependencies actually work, rather than re-compiling every time I used 1 point on this task today, can you add what you used yesterday? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32798#comment:3> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs