#28745: THE Torbutton clean-up -------------------------------------------------+------------------------- Reporter: gk | Owner: acat Type: defect | Status: | needs_review Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-torbutton, | Actual Points: TorBrowserTeam202001R | Parent ID: #30506 | Points: Reviewer: gk | Sponsor: -------------------------------------------------+------------------------- Changes (by acat):
* keywords: tbb-torbutton, TorBrowserTeam202001 => tbb-torbutton, TorBrowserTeam202001R * status: needs_revision => needs_review Comment: Replying to [comment:28 gk]: > Okay, let's move on with the review process, commit 8269902a22357697c46c7052c9d946bd874c3f55: > > Looks mostly good. It misses a `tor-browser` change to remove the `extensions.torbutton.updateNeeded` and `extensions.torbutton.versioncheck_enabled` pref, now that we moved the preferences. Additionally, please remove the `torbutton-update-needed.svg` as well. It seems to be obsolete now, too. > > For 8c0c18a09a30f14dd0b4a99fe67238fec0ad3bac what command did you run/tool did you use to check for those errors (and fix them)? Hmm, i can't find `8269902a22357697c46c7052c9d946bd874c3f55` commit, I assume it was from `torbutton` (I hope it was not `push --force` again). In any case, I removed the mentioned prefs and some more that are now unused from `000-tor-browser-prefs.js`: https://github.com/acatarineu/tor- browser/commit/28745+3. Some are unused because of changes already commited, some are due to `torbutton` changes from this ticket not yet commited. I also rebased the torbutton changes from `28745+4` to current master, and removed `torbutton-updated-needed.svg`. Besides, I split the style- changing commits into two, the ones automatically done by eslint tool, and the remaining ones that had to be addressed manually. Changes are in https://github.com/acatarineu/torbutton/commits/28745+5. The command to fix `eslint` issues was `./mach lint -l eslint --fix toolkit/torproject/torbutton`, run in the `tor-browser` repo with the right `torbutton` repo temporarily checked in in `toolkit/torproject/torbutton` (this time I also had to run `./mach bootstrap --no-system-changes` with Desktop selected before, which is new). -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28745#comment:32> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs