#32778: pubsub_pub_ -------------------------------------------------+------------------------- Reporter: cypherpunks | Owner: nickm Type: defect | Status: | merge_ready Priority: High | Milestone: Tor: | 0.4.2.x-final Component: Core Tor/Tor | Version: Tor: | 0.4.1.1-alpha Severity: Normal | Resolution: Keywords: consider-backport-after-043-stable, | Actual Points: .2 041-backport 042-backport extra-review crash | regression 043-must | Parent ID: | Points: Reviewer: catalyst | Sponsor: -------------------------------------------------+------------------------- Changes (by teor):
* keywords: 041-backport 042-backport extra-review crash regression 043-must => consider-backport-after-043-stable, 041-backport 042-backport extra- review crash regression 043-must * milestone: Tor: 0.4.3.x-final => Tor: 0.4.2.x-final * version: Tor: 0.4.2.5 => Tor: 0.4.1.1-alpha * actualpoints: .1 => .2 Comment: There was a conflict with #32883, which replaces the pubsub calls added in this ticket, with calls to `tor_run_main()` (which then calls the pubsub functions). Therefore, I did an "ours" merge, to avoid taking any changes from this PR in master. (But resolve future conflicts when we backport this change.) Unfortunately, the "ours" merge means that this code won't be tested in master. But this PR seems reasonable to me for backport. The pattern of calls in `nt_service_main()` and `nt_service_body()` matches the pubsub call pattern used by other platforms in `tor_run_main()` before #32883. (And used by all platforms after #32883.) Given the lack of testing, I'm marking it for backport after 0.4.3-stable. Merged to master with #32705. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32778#comment:19> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs