#33011: Remove erroneous logging around pt.*Error calls -----------------------------------------+---------------------- Reporter: dcf | Owner: dcf Type: defect | Status: assigned Priority: Medium | Milestone: Component: Circumvention/Snowflake | Version: Severity: Normal | Keywords: Actual Points: | Parent ID: Points: | Reviewer: Sponsor: | -----------------------------------------+---------------------- #31794 added logging around every function call that returns an `error` type; but this is the wrong thing to do in the case of functions like [https://godoc.org/git.torproject.org/pluggable- transports/goptlib.git#CmethodError pt.CmethodError], [https://godoc.org/git.torproject.org/pluggable- transports/goptlib.git#SmethodError pt.SmethodError], and [https://godoc.org/git.torproject.org/pluggable- transports/goptlib.git#ProxyError pt.ProxyError]. These functions are called for their side effect of sending a PT error message on stdout; it happens that they also return a representation of the error message as an `error` object for the caller to use if it wishes. They ''always'' return a non-`nil` `error` object; a non-`nil` error is not an exceptional event to be logged.
-- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33011> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs