#33029: dir-auth: Dir auths should resume sending 503's but never to relays or other dir auths -------------------------------------+------------------------------------ Reporter: dgoulet | Owner: dgoulet Type: defect | Status: needs_review Priority: Medium | Milestone: Tor: 0.4.3.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-dirauth 043-should? | Actual Points: Parent ID: #33018 | Points: 0.4 Reviewer: nickm, teor, armadev | Sponsor: -------------------------------------+------------------------------------
Comment (by arma): Thanks, dgoulet, the new (fixed up, squashed) branch looks great. And while I'm here, here is a minimal patch for Tor stables that I think will do everything we need. We might choose to do something else for an official backport, but in the meantime I'll offer this one to dir auth operators who want to patch but don't want to move to git master and don't want to examine six commits themselves. {{{ index 6094f33e4d..b0687dc2fd 100644 --- a/src/core/mainloop/connection.c +++ b/src/core/mainloop/connection.c @@ -3212,7 +3212,8 @@ global_write_bucket_low(connection_t *conn, size_t attempt, int priority) MIN(token_bucket_rw_get_write(&global_bucket), token_bucket_rw_get_write(&global_relayed_bucket)); if (authdir_mode(get_options()) && priority>1) - return 0; /* there's always room to answer v2 if we're an auth dir */ + if (nodelist_probably_contains_address(&conn->addr)) + return 0; /* always answer relays if we're an auth dir */ if (!connection_is_rate_limited(conn)) return 0; /* local conns don't get limited */ }}} -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33029#comment:18> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs