#31011: Make the bridge authority reject private PT addresses when DirAllowPrivateAddresses is 0 --------------------------+------------------------------------ Reporter: teor | Owner: cjb Type: defect | Status: needs_review Priority: Medium | Milestone: Tor: 0.4.4.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: #31009 | Points: 1 Reviewer: | Sponsor: Sponsor28-can --------------------------+------------------------------------
Comment (by teor): Replying to [comment:16 cjb]: > Oh, something to mention: > > > `if (tor_addr_port_parse(LOG_WARN, bindaddr, &tor_addr, &tor_port, 0) > -1 &&` > > This patch will only reject an internal address if it successfully passes `tor_addr_port_parse`. I was worried that there might be a valid `ServerTransportListenAddr` that fails `tor_addr_port_parse` and didn't think we should reject the config in that case. Does that sound reasonable? We shouldn't restrict future pluggable transport addresses too much. (`ServerTransportListenAddr` is parsed by the PT, so it's possible that tor won't understand it.) In this case, I think we should log a warning or notice-level message. Because it is still likely to be a misconfiguration. (Im pretty sure tor understands all current PT addresses.) -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31011#comment:17> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs