#30733: sbws does not detect changes in descriptor bandwidth values -------------------------------------------------+------------------------- Reporter: starlight | Owner: juga Type: defect | Status: | merge_ready Priority: Very High | Milestone: sbws: | 1.1.x-final Component: Core Tor/sbws | Version: sbws: | 1.1.0 Severity: Critical | Resolution: Keywords: sbws-majority-blocker, sbws-roadmap | Actual Points: Parent ID: #33121 | Points: 1 Reviewer: asn | Sponsor: -------------------------------------------------+------------------------- Changes (by asn):
* status: needs_review => merge_ready Comment: Code looks reasonable to me. It would be nice if the new code was also tested. Also, you might want to check dormant mode and see if you need to disable that too, since if your tor thinks you are not using it, it will go dormant in 24h and stop downloading consensuses etc. The right way to disable dormant mode is to send the `ACTIVE` signal with the controller every once in a while. I'm not sure if this applies in your case, but I noticed the new torrc options you added are relevant. I'm marking this as merge_ready for the purposes of code review, but you might wan to add unittests and check the dormant thing. If you do, let me know and i can review your changes as well. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30733#comment:41> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs