#33144: Overhaul websocketconn.Conn; implement net.Conn -------------------------------------+----------------------------- Reporter: dcf | Owner: dcf Type: enhancement | Status: merge_ready Priority: Medium | Milestone: Component: Circumvention/Snowflake | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: cohosh | Sponsor: -------------------------------------+----------------------------- Changes (by cohosh):
* status: needs_review => merge_ready Comment: Nice! This is a really clean implementation. Thanks for working on this. My only question is about the different write methods used in the tests at [https://gitweb.torproject.org/user/dcf/snowflake.git/tree/common/websocketconn/websocketconn_test.go?h=bug33144-websocketconn&id=4a13694eefc21a11a2a9df5a59bbfba90a9e38da#n173 L173] vs [https://gitweb.torproject.org/user/dcf/snowflake.git/tree/common/websocketconn/websocketconn_test.go?h=bug33144-websocketconn&id=4a13694eefc21a11a2a9df5a59bbfba90a9e38da#n207 L207]. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33144#comment:4> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs