#30237: Tor Browser: Improve TBB UI of hidden service client authorization -------------------------------------------------+------------------------- Reporter: asn | Owner: mcs Type: defect | Status: | needs_review Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: network-team-roadmap-september, | Actual Points: 16.1 TorBrowserTeam202001R network-team-roadmap- | 2020Q1 | Parent ID: #30000 | Points: 17 Reviewer: pospeselr, sysrqb | Sponsor: | Sponsor27-must -------------------------------------------------+-------------------------
Comment (by sysrqb): Replying to [comment:51 mcs]: > Kathy and I rebased the patches to the `tor-browser-68.4.1esr-9.5-1` branch. The patch is here: > https://gitweb.torproject.org/user/brade/tor- browser.git/commit/?h=bug30237-04&id=6cac185d0c10e4f26ca7eaf000c31fae36d13bfc {{{ + let retval = { + learnMore: getString("torPreferences.learnMore", "Learn More"), + learnMoreURL: `https://2019.www.torproject.org/docs/tor-manual- dev.html.${getLocale()}#_client_authorization`, }}} I know that's waiting on #31069 but :( {{{ + * - [optional] leaveOpen (boolean): If this is true, the notification + * will not be removed after running the callback. * - [optional] disableHighlight (boolean): If this is true, the button * will not apply the default highlight style. * If null, the notification will have a default "OK" action button @@ -1863,6 +1865,10 @@ PopupNotifications.prototype = { this._dismiss(); return; } + + if (action.leaveOpen) { + return; }}} I wonder if we can uplift this. > > We also rebased the Tor Launcher change so it is based off current master: > https://gitweb.torproject.org/user/brade/tor- launcher.git/commit/?h=bug30237-04&id=8726dc9a06524edc03d053a3258652dd9337ef78 Looks good. `ExtendedErrors` was released in `0.4.3.1-alpha`, so we can try this in the next release. > > Finally, we made a couple of small improvements to the control port module in Torbutton; these are new changes that should be reviewed: > https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug30237-04&id=9dbc7d20a0efbe6d6d085950c937ed223176e6fa Looks good to me. I didn't see any major problems in these patches. Thanks for all the work you put into this! Let's see how this looks on nightly. tor-browser: `28641dbae674f58429aa3518342555a6b977342e` tor-launcher: `8726dc9a06524edc03d053a3258652dd9337ef78` torbutton: `9dbc7d20a0efbe6d6d085950c937ed223176e6fa` -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30237#comment:55> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs