#30767: Custom obfs4 bridge does not work on Tor Browser for Android -------------------------------------------------+------------------------- Reporter: gk | Owner: sisbell Type: defect | Status: | needs_revision Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-parity, tbb-mobile, | Actual Points: TorBrowserTeam202001R | Parent ID: #31284 | Points: 0.5 Reviewer: sysrqb | Sponsor: | Sponsor30-can -------------------------------------------------+-------------------------
Comment (by sysrqb): Replying to [comment:25 sisbell]: > Replying to [comment:24 sysrqb]: > > Replying to [comment:19 sisbell]: > > > I made the following changes: > > > * We no longer filter bridges based on type > > > * Write out UseBridges, only if explicitly set > > > > > > The filter part was supporting a filter feature from orbot that I don't think was fully baked since it only supported an either/or meek/obfs option. Filtering is a useful option but we should open an issue for that and come up with a more general solution. This is a breaking change with Orbot. > > > > > > https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/d05797385127876889d6d7a8e8fc8cc45d8cccdd > > > > This patch should unconditionally call `transportPluginObfs()` and `transportPluginMeek()` in `configurePluggableTransportsFromSettings()` after it checks that the file exists and is executable. We don't care if the transport is part of the `supportedBridges` list because they aren't related. > > > > I also mentioned earlier that we can simply combine the `transportPlugin*()` methods, and that can output a single line containing all of the transports (`ClientTransportPlugin meek_lite,obfs3,obfs4 exec`). > If we don't need to check the supported bridges, then collapsing the transport line is super easy. I'll make these changes. Great, thanks. I pushed a branch with a possible fixup commit. Feel free to use it or not. https://gitweb.torproject.org/user/sysrqb/tor-onion-proxy- library.git/commit/?h=bug30767&id=63fad679212838268935b45f12ec3f9ab61a4e5f -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30767#comment:26> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs