#33191: Write database tests for twisted adbapi for GetTor
---------------------------------+------------------------------
Reporter: cohosh | Owner: cohosh
Type: task | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/GetTor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points: .5
Reviewer: hiro | Sponsor:
---------------------------------+------------------------------
Changes (by cohosh):
* status: needs_revision => needs_review
Comment:
Okay here's a merge request that implements working database tests while
sticking with the twisted adbapi.
https://dip.torproject.org/cohosh/gettor/merge_requests/9
Note that
[https://dip.torproject.org/cohosh/gettor/merge_requests/9/diffs?commit_id=c413a8ebdaf1c70bc40255e35e7917165fa75552
one commit] actually makes changes to how the database code is called in
gettor. Specifically, we weren't ever closing the connection to the
database in the gettor code. This should fix that bug as well as get our
tests running cleanly.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33191#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
