#33215: Android Toolchain: Add NDK bin path to system path
-------------------------------------------------+-------------------------
Reporter: sisbell | Owner: tbb-
| team
Type: defect | Status:
| needs_information
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, tbb-rbm, tbb-parity, | Actual Points:
TorBrowserTeam202002 |
Parent ID: #28704 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by sisbell):
Replying to [comment:1 sysrqb]:
> This is based on commit f5fdff3bf0b9e957ab011f95af9e215cca7aeed6 from
ticket:28704#comment:23.
>
> {{{
> diff --git a/projects/android-toolchain/config b/projects/android-
toolchain/config
> index 8c9c8222..4c02b2f3 100644
> --- a/projects/android-toolchain/config
> +++ b/projects/android-toolchain/config
> @@ -15,6 +15,7 @@ var:
> export GRADLE_HOME=/var/tmp/dist/[% project %]/gradle
> export ANDROID_HOME=$ANDROID_SDK_HOME
> export GRADLE_USER_HOME=$GRADLE_HOME
> + export PATH=$ANDROID_NDK_HOME/[% c("var/toolchain_arch")
%]/bin:$PATH
> }}}
> If we put the toolchain at the end, are there situations where a system
executable is used instead of the Android toolchain?
I'll need to check old logs, but yes some projects just look for clang
without the host info so it picks up the system executable for clang.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33215#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
