#32563: Merge HSv3 spec fixes we found during onionbalance creation -------------------------------------------------+------------------------- Reporter: asn | Owner: asn Type: defect | Status: | needs_revision Priority: Medium | Milestone: Tor: | unspecified Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-hs, scaling, onionbalance, | Actual Points: network-team-roadmap-september, tor-spec, | network-team-roadmap-2020Q1 | Parent ID: #26768 | Points: 0.2 Reviewer: dgoulet | Sponsor: | Sponsor27-must -------------------------------------------------+-------------------------
Comment (by asn): Replying to [comment:9 dgoulet]: > I think we need to define the length in bytes for `mac_key_len` and `salt_len` ? > > Code is forcing it to 8 bytes: > > {{{ > crypto_digest_add_bytes(digest, (const char *) &mac_len_netorder, 8); > crypto_digest_add_bytes(digest, (const char *) &salt_len_netorder, 8); > }}} Hey. Isn't `htonll` already specifying that it's a `uint64_t` and hence 8 bytes? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32563#comment:10> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs