#32994: Get all flag defaults from port_cfg_new() -------------------------------------------------+------------------------- Reporter: teor | Owner: | MrSquanchee Type: defect | Status: | assigned Priority: Medium | Milestone: Tor: | unspecified Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: technical-debt, tor-client, easy, | Actual Points: intro, outreachy-ipv6 | Parent ID: | Points: 1 Reviewer: | Sponsor: -------------------------------------------------+-------------------------
Comment (by MrSquanchee): I changed the code of `port_parse_config()` successfully accommodating a `port_config_t` object. But still I can't see a necessity of a default `port_config_t` in `connection_listener_new()` because it's just memcopying in ln1500 https://gitweb.torproject.org/tor.git/tree/src/core/mainloop/connection.c#n1500 and setting the traffic values conditionally here at https://gitweb.torproject.org/tor.git/tree/src/core/mainloop/connection.c#n1517 . So it doesn't seem nice to me to give them defaults without checking the condition at line 1517. Suggest me if I should send a PR on github.com. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32994#comment:10> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs