#33679: Make sure every address function that takes for_listening supports IPv6 -------------------------------------------+------------------------------- Reporter: teor | Owner: MrSquanchee Type: task | Status: | needs_revision Priority: Medium | Milestone: Tor: | 0.4.4.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: prop312, ipv6, outreachy-ipv6 | Actual Points: Parent ID: #33049 | Points: 0.5 Reviewer: | Sponsor: | Sponsor55-must -------------------------------------------+-------------------------------
Comment (by MrSquanchee): Hii teor, I want you to look at this, Either tor_addr_is_null() is failing (which I don't see any reason to) or tor_inet_pton() is. Have a look at my updated PR[https://github.com/torproject/tor/pull/1831]. I have added the required tests. And I didn't see any reasons to change tor_port_is_valid(). However I refactored tor_addr_is_valid_ipv4n() and I don't see any reason to make a similar function for ipv6 as it will only be checking whether it's null or not and that could be done via tor_is_valid(). -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33679#comment:4> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs