#31634: Check .may_include order and tor subsystem init order are compatible --------------------------------------+------------------------------------ Reporter: teor | Owner: nickm Type: enhancement | Status: needs_revision Priority: Medium | Milestone: Tor: 0.4.4.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: diagnostics, practracker | Actual Points: 0.5 Parent ID: | Points: 2 Reviewer: teor | Sponsor: --------------------------------------+------------------------------------ Changes (by teor):
* status: needs_review => needs_revision Comment: Travis distcheck CI failed with: {{{ Traceback (most recent call last): File "/home/travis/build/torproject/tor/tor-0.4.4.0-alpha- dev/_build/sub/../../scripts/maint/practracker/includes.py", line 348, in <module> main(sys.argv) File "/home/travis/build/torproject/tor/tor-0.4.4.0-alpha- dev/_build/sub/../../scripts/maint/practracker/includes.py", line 345, in main check_subsystem_order=args.check_subsystem_order) File "/home/travis/build/torproject/tor/tor-0.4.4.0-alpha- dev/_build/sub/../../scripts/maint/practracker/includes.py", line 309, in run_check_includes if check_subsys_file(check_subsystem_order, uses_dirs): File "/home/travis/build/torproject/tor/tor-0.4.4.0-alpha- dev/_build/sub/../../scripts/maint/practracker/includes.py", line 275, in check_subsys_file if fname in uses_closure[prev]: KeyError: u'lib/llharden' FAIL scripts/maint/run_check_subsystem_order.sh (exit status: 1) }}} Appveyor CI failed with a similar error: {{{ Traceback (most recent call last): File "C:/projects/tor/x86_64-w64-mingw32/../scripts/maint/practracker/includes.py", line 348, in <module> main(sys.argv) File "C:/projects/tor/x86_64-w64-mingw32/../scripts/maint/practracker/includes.py", line 341, in main run_check_includes(topdir=args.topdir, File "C:/projects/tor/x86_64-w64-mingw32/../scripts/maint/practracker/includes.py", line 309, in run_check_includes if check_subsys_file(check_subsystem_order, uses_dirs): File "C:/projects/tor/x86_64-w64-mingw32/../scripts/maint/practracker/includes.py", line 275, in check_subsys_file if fname in uses_closure[prev]: KeyError: 'lib/llharden' FAIL scripts/maint/run_check_subsystem_order.sh (exit status: 1) }}} Otherwise the changes look good. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31634#comment:16> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs