#33992: Treat securedrop.tor.onion as eTLD --------------------------------------+-------------------------------- Reporter: sysrqb | Owner: tbb-team Type: defect | Status: needs_revision Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: TorBrowserTeam202004 | Actual Points: Parent ID: | Points: Reviewer: acat, gk | Sponsor: --------------------------------------+-------------------------------- Changes (by gk):
* keywords: TorBrowserTeam202004R => TorBrowserTeam202004 * status: needs_review => needs_revision Comment: Overall, looks good. I feel though it might be worth moving the code blocks a bit around. Could you move {{{ + // Drop '.securedrop.tor.onion' suffix, and keep track of it for later + NS_NAMED_LITERAL_CSTRING(dotSDTO, ".securedrop.tor.onion"); + const bool sdtoSuffix = StringEndsWith(aHostname, dotSDTO); + if (sdtoSuffix) aHostname.Truncate(aHostname.Length() - dotSDTO.Length()); + }}} after the edge case check. I feel both the one before and after your change should stay grouped together. Additionally, could we move the other two changes before the repsective `aBaseDomain.Append('.');` parts? We remove the `.` first and we should add them therefore last again. I still need to test the changes. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33992#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs