#18741: OCSP and favicon isolation is only partly working in ESR 45 -------------------------------------------------+------------------------- Reporter: gk | Owner: tbb- Type: defect | team Priority: High | Status: Component: Applications/Tor Browser | needs_review Severity: Major | Milestone: Keywords: ff45-esr, tbb-6.0a5, | Version: TorBrowserTeam201604R | Resolution: Parent ID: | Actual Points: Reviewer: | Points: | Sponsor: -------------------------------------------------+-------------------------
Comment (by mcs): Replying to [comment:11 gk]: > [snip] > Sounds like a good approach we could test in the alpha. One nit: > > There is no need for an additional `node->IsElement()` check as you are landing in the `if`-block only after the `node->IsElement()` check passes. Yes, r=brade and r=mcs if you remove the extra IsElement() check. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18741#comment:12> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs