#18809: Handle linked connections better during bootstrap -------------------------------------------------+------------------------- Reporter: teor | Owner: Type: defect | Status: Priority: Medium | needs_review Component: Core Tor/Tor | Milestone: Tor: Severity: Normal | 0.2.8.x-final Keywords: must-fix-before-028-rc, | Version: Tor: TorCoreTeam201605 | 0.2.8.1-alpha Parent ID: | Resolution: Reviewer: teor | Actual Points: | Points: | Sponsor: -------------------------------------------------+-------------------------
Comment (by dgoulet): * Commit `33335b8` DG1: Just after we set `answer = 1`, we should break. There is no need to continue the loop. {{{ + !AP_CONN_STATE_IS_UNATTACHED(base->linked_conn->state)) + answer = 1; }}} * Commit `a9012a61fafae3ca8c6ae40ba5f433dcf12aad71` DG2: There is an awful lot of code removal in there but the commit message doesn't tell me why nor what is being removed here. This is an interesting change, we go from a callback every second trying to cleanup to a function call only done when we successfully receive a consensus. The whole logic of this patch seems OK to me. Let's fix those unit tests :). -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18809#comment:8> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs