#18977: correct_tm() doesn't set r->tm_wday, but format_rfc1123_time() uses it -------------------------------------------------+------------------------- Reporter: teor | Owner: nickm Type: defect | Status: Priority: Medium | needs_review Component: Core Tor/Tor | Milestone: Tor: Severity: Normal | 0.2.8.x-final Keywords: 028-proposed 025-backport | Version: Tor: 026-backport 027-backport | 0.2.8.2-alpha Parent ID: | Resolution: Reviewer: | Actual Points: | Points: small | Sponsor: -------------------------------------------------+------------------------- Changes (by nickm):
* status: needs_revision => needs_review Comment: Replying to [comment:4 teor]: > Code review: > > T1: There are 4 cases, but only 3/4 set tm_wday. bug18977_024 now has a fixup commit, but I don't know if I got the case you meant. If I didn't, please let me know where it is? [...] > Given the simplicity of this patch, and the fact that a failure causes a crash, I suggest we backport it to 0.2.4 (the latest running version on the network) onwards. Okay. Let's try on 0.2.7+, and backport ad libitum. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18977#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs