brizental pushed to branch base-browser-140.3.0esr-15.0-1 at The Tor Project /
Applications / Tor Browser
Commits:
abb1e4ff by Beatriz Rizental at 2025-09-17T18:00:37+02:00
fixup! BB 42630: Disable LaterRun module.
This reverts commit 39ef92aa875d836b6c1d8e0c42de0eeeedd4403f.
- - - - -
420dbea1 by Beatriz Rizental at 2025-09-17T18:00:38+02:00
fixup! Firefox preference overrides.
Disable LaterRun using a preference.
- - - - -
0c52d15d by Beatriz Rizental at 2025-09-17T18:00:39+02:00
fixup! BB 42027: Base Browser migration procedures.
Clear LaterRun metadata preferences.
- - - - -
3 changed files:
- browser/app/profile/001-base-profile.js
- browser/components/ProfileDataUpgrader.sys.mjs
- browser/modules/LaterRun.sys.mjs
Changes:
=====================================
browser/app/profile/001-base-profile.js
=====================================
@@ -1087,3 +1087,10 @@ pref("font.name-list.monospace.x-unicode", "Cousine,
Noto Sans Balinese, Noto Sa
// The rest are not customized, because they are covered only by one font
#endif
#endif
+
+// tor-browser#42630: Disable LaterRun.
+//
+// This preference is set in a few places in code. Even though it's locked,
+// setting it will still change the value in `prefs.js`, but it will be
ignored.
+// If this is ever unlocked, the value in prefs.js will be used.
+pref("browser.laterrun.enabled", false, locked);
=====================================
browser/components/ProfileDataUpgrader.sys.mjs
=====================================
@@ -913,7 +913,8 @@ export let ProfileDataUpgrader = {
// hid its neterror checkbox. tor-browser#42653.
// Version 3: 14.0a7: Reset general.smoothScroll. tor-browser#42070.
// Version 4: 15.0a2: Drop ML components. tor-browser#44045.
- const MIGRATION_VERSION = 4;
+ // Version 5: 15.0a3: Disable LaterRun using prefs. tor-browser#42630.
+ const MIGRATION_VERSION = 5;
const MIGRATION_PREF = "basebrowser.migration.version";
if (isNewProfile) {
@@ -972,6 +973,15 @@ export let ProfileDataUpgrader = {
Services.prefs.clearUserPref(prefName);
}
}
+ if (currentVersion < 5) {
+ for (const prefName of [
+ "browser.laterrun.bookkeeping.sessionCount",
+ "browser.laterrun.bookkeeping.profileCreationTime",
+ "browser.laterrun.bookkeeping.updateAppliedTime",
+ ]) {
+ Services.prefs.clearUserPref(prefName);
+ }
+ }
Services.prefs.setIntPref(MIGRATION_PREF, MIGRATION_VERSION);
},
};
=====================================
browser/modules/LaterRun.sys.mjs
=====================================
@@ -61,20 +61,6 @@ export let LaterRun = {
},
init(reason) {
- // Keep disabled in Base Browser. See tor-browser#41568.
- // NOTE: This means that users cannot benefit from feature prompts gated
- // behind LaterRun.
- // In mozilla ESR 128 it is only used in one place, and is gated behind a
- // feature recommendation preference that we switch off in Base Browser
- // anyway. See tor-browser#42630.
- // But this decision should be reviewed. See tor-browser#43093.
- Services.prefs.setBoolPref(kEnabledPref, false);
- // Clear any preferences that may have been set before LaterRun was
- // disabled.
- Services.prefs.clearUserPref(kSessionCountPref);
- Services.prefs.clearUserPref(kProfileCreationTime);
- Services.prefs.clearUserPref(kUpdateAppliedTime);
-
if (!this.enabled) {
return;
}
@@ -113,8 +99,11 @@ export let LaterRun = {
return Services.prefs.getBoolPref(kEnabledPref, false);
},
- enable(_reason) {
- // Keep disabled in Base Browser. See tor-browser#41568.
+ enable(reason) {
+ if (!this.enabled) {
+ Services.prefs.setBoolPref(kEnabledPref, true);
+ this.init(reason);
+ }
},
get hoursSinceInstall() {
View it on GitLab:
https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/5e6921321b766f8e9fef80f9b89df87fd9538df4...0c52d15dd2467ec484a05720b081589c5bb8f900
--
View it on GitLab:
https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/5e6921321b766f8e9fef80f9b89df87fd9538df4...0c52d15dd2467ec484a05720b081589c5bb8f900
You're receiving this email because of your account on gitlab.torproject.org.
_______________________________________________
tor-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
