commit 55e760cef839755717d3d9891b8f3d195e18d0e6
Author: Isis Lovecruft <i...@torproject.org>
Date: Wed Jun 25 00:00:41 2014 +0000
Add TODO: bridgedb.Bridges.BridgeBlock should be a zope.interface.Interface.
This does not count as a base class. There is absolutely no point to
it. I haven't bothered to do a git blame to see whose idea this was; it
doesn't matter. This is NOT A BASE CLASS. Especially when it is an
old-style class without a proper method resolution ordering algorithm.
---
lib/bridgedb/Bridges.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/bridgedb/Bridges.py b/lib/bridgedb/Bridges.py
index 0cc9e1f..2439130 100644
--- a/lib/bridgedb/Bridges.py
+++ b/lib/bridgedb/Bridges.py
@@ -1424,7 +1424,10 @@ class FilteredBridgeSplitter(BridgeHolder):
class BridgeBlock(object):
- """Base class that abstracts bridge blocking"""
+ """Base class that abstracts bridge blocking.
+
+ .. TODO:: This should be a zope.interface specification.
+ """
def __init__(self):
pass
_______________________________________________
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits
