First, thank you Thomas F for keeping up moving forward! +1 on Thomas V's alias column object.
No strong opinion on the flag issue. -----Original Message----- From: Thomas Vandahl [mailto:[email protected]] Sent: Wednesday, December 28, 2011 8:43 AM To: Apache Torque Developers List Subject: Re: Change semantics of Criteria.add() and Criteria.or() On 27.12.11 10:46, Thomas Fox wrote: > On checking the test, I discovered that there is a "valid" use case for > String column namnes even if one uses the generated code, namely aliases. I don't know what exact use case you have in mind but I propose to provide a method to create a Column object for aliases and remove the string-based methods altogether. > # creates methods which take the old org.apache.torque.util.Criteria object > torque.use.util.criteria > # creates methods which take the new org.apache.torque.criteria.Criteria > object > torque.use.criteria.criteria > > In my opinion, the default value of both options should be true. What do > you think ? IMHO, it the time for radical changes is now. So I suggest to support only one flag to switch using either the old or the new class but not both. Bye, Thomas. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] DukeCE Privacy Statement: Please be advised that this e-mail and any files transmitted with it are confidential communication or may otherwise be privileged or confidential and are intended solely for the individual or entity to whom they are addressed. If you are not the intended recipient you may not rely on the contents of this email or any attachments, and we ask that you please not read, copy or retransmit this communication, but reply to the sender and destroy the email, its contents, and all copies thereof immediately. Any unauthorized dissemination, distribution or copying of this communication is strictly prohibited. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
