Author: tfischer
Date: Thu May 16 08:21:56 2013
New Revision: 1483239
URL: http://svn.apache.org/r1483239
Log:
Exclude false positives from findbugs analysis
fix javadoc
Modified:
db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/ModelPropertyPointer.java
db/torque/torque4/trunk/torque-generator/src/main/plugin-config/findbugs-exclude.xml
Modified:
db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/ModelPropertyPointer.java
URL:
http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/ModelPropertyPointer.java?rev=1483239&r1=1483238&r2=1483239&view=diff
==============================================================================
---
db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/ModelPropertyPointer.java
(original)
+++
db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/ModelPropertyPointer.java
Thu May 16 08:21:56 2013
@@ -112,8 +112,9 @@ public class ModelPropertyPointer extend
}
/**
- * Get the names of all properties, sorted alphabetically
- * @return String[]
+ * Get the names of all properties, sorted alphabetically.
+ *
+ * @return the names of all properties, not null.
*/
@Override
public String[] getPropertyNames()
Modified:
db/torque/torque4/trunk/torque-generator/src/main/plugin-config/findbugs-exclude.xml
URL:
http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-generator/src/main/plugin-config/findbugs-exclude.xml?rev=1483239&r1=1483238&r2=1483239&view=diff
==============================================================================
---
db/torque/torque4/trunk/torque-generator/src/main/plugin-config/findbugs-exclude.xml
(original)
+++
db/torque/torque4/trunk/torque-generator/src/main/plugin-config/findbugs-exclude.xml
Thu May 16 08:21:56 2013
@@ -52,4 +52,14 @@
<Class name="org.apache.torque.generator.outlet.OutletResult" />
<Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2" />
</Match>
+ <Match>
+ <!--
+ getPropertyDescriptor caches the result for efficiency.
+ While in principle this can be misused, the current version of
+ commons-jxpath doesn't.
+ -->
+ <Class name="org.apache.torque.generator.source.ModelPropertyPointer" />
+ <Method name="getPropertyDescriptor" />
+ <Bug pattern="EI_EXPOSE_REP" />
+ </Match>
</FindBugsFilter>
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]