Author: tfischer
Date: Sun Sep 21 14:52:05 2014
New Revision: 1626586
URL: http://svn.apache.org/r1626586
Log:
Fix findbugs problem:
org.apache.torque.generator.source.stream.FileSource.getContentChecksum() may
expose internal representation by returning FileSource.contentMd5Sum
Modified:
db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/stream/FileSource.java
Modified:
db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/stream/FileSource.java
URL:
http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/stream/FileSource.java?rev=1626586&r1=1626585&r2=1626586&view=diff
==============================================================================
---
db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/stream/FileSource.java
(original)
+++
db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/stream/FileSource.java
Sun Sep 21 14:52:05 2014
@@ -27,6 +27,7 @@ import java.io.InputStream;
import java.security.DigestInputStream;
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
+import java.util.Arrays;
import java.util.Date;
import org.apache.commons.logging.Log;
@@ -237,10 +238,14 @@ public class FileSource extends SourceIm
}
catch (SourceException e)
{
- // do nothing, contentMd5Sum remains null
+ // contentMd5Sum remains as set by getRootElement()
}
}
- return contentMd5Sum;
+ if (contentMd5Sum == null)
+ {
+ return null;
+ }
+ return Arrays.copyOf(contentMd5Sum, contentMd5Sum.length);
}
@Override
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
