[ https://issues.apache.org/jira/browse/TORQUE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174391#comment-15174391 ]
Thomas Fox commented on TORQUE-342: ----------------------------------- Removing the throws clause in generation can break compiletime compatibility, casue TorqueException is a checked exception, and if it is the only occurence in a catch block the compiler will throw an error. However I am fine with removing the throws declaration in the template because the change would clarify that no TorqueException will ever be thrown there. > XXXPeer.addSelectColumns() is declared to throw TorqueException for no > apparent reason > -------------------------------------------------------------------------------------- > > Key: TORQUE-342 > URL: https://issues.apache.org/jira/browse/TORQUE-342 > Project: Torque > Issue Type: Improvement > Components: Templates > Affects Versions: 4.0 > Reporter: Thomas Vandahl > Priority: Minor > Fix For: 4.1 > > > For example {{AuthorPeer.addSelectColumns()}} is declared as > {code:java} > public static void addSelectColumns(Criteria criteria) > throws TorqueException > { > getAuthorPeerImpl().addSelectColumns(criteria); > } > {code} > {{getAuthorPeerImpl().addSelectColumns(criteria)}}, however actually calls > {{BasePeerImpl.addSelectColumns(criteria)}} which does not throw any > exceptions. Is this a leftover from previous times when the columns were > drawn from the MapBuilders? -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscr...@db.apache.org For additional commands, e-mail: torque-dev-h...@db.apache.org