New issue 347: Use the "Skip Diff Window" setting for "THG > Visual Diff" menu command http://bitbucket.org/tortoisehg/stable/issue/347/use-the-skip-diff-window-setting-for-thg-visual-diff-menu
DannyWan on Thu, 2 Jul 2009 05:47:51 +0200: Description: Hi, There's an option in the settings to "Skip the Diff Window" (in the "TortoiseHG" panel). In version 0.8, this option is not used because the extdiff doesn't give any feedback in case of nothing to diff. So always using the diff window at least provide feedback to the user. But on the other hand, in most of the case the user still have a window he would prefer to skip. Currently if you do a "THG > Visual Diff" on an unmodified file (or unmodified folder) the THG diff window will display a dialog box saying "There are no file changes to view" with a close button, which is good. My suggestion of enhancement would be to split the behavior in two. If I do a "THG > Visual Diff": * first you start by doing the normal code of the visual diff window that collect the list of modified files, * if there is no modification, you display the same dialog box, * if there are modification, you check the setting option "Skip the Diff Window" * if the setting is not set or set to false you can continue to display the diff window * if the setting is set to true, you skip it and launch the extdiff tool So in that case you can provide feedback to the user in both situation and still satisfy his preference. Bye. Responsible: tortoisehg -- This is an issue notification from bitbucket.org. You are receiving this either because you are the owner of the issue, or you are following the issue. ------------------------------------------------------------------------------ _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
