Issue 342: Explorer crash with vdiff command
http://bitbucket.org/tortoisehg/stable/issue/342/explorer-crash-with-vdiff-command
Adrian Buehlmann / abuehl on Mon, 6 Jul 2009 10:50:49 +0200:
Comment:
Yes, it is right. The only hard limit is the size of the target buffer, which
is not specified. The requirement spec of the function (see the msdn link I
provided) does **not** require to truncate strings at 40 characters (or any
other size).
Yes, there is already one help string in the English hard coded texts that is
longer than 40 characters. I've noticed that too.
I have added the warning in the code so that it is easier to find these.
Relevant debug out excerpt:
{{{
[3136] [THG] CShellExt::GetCommandString: name = "recover"
[3136] [THG] CShellExt::GetCommandString: warning: length of help text is 41,
which is not reasonably short (<40)
[3136] [THG] CShellExt::GetCommandString: res = 0, pszName = "General repair
and recovery of repository"
}}}
The original implementation of the cmenu code did not obey any limits. Since I
started hacking on the cmenu part, I tried to improve it. We are gradually
maturing the code, as it evolved from experimental status as published by TK
Soh (which provided the excellent starting point for the new C++ shell
extension) to its first release (0.8). Nevertheless, the quality of this first
release is not that bad, IMHO.
40 characters is indeed very short. I understand that it is difficult to stay
under 40 in verbose languages like Italian. German (my domain, I'm Swiss-German
speaking -- Bernese German, to be axact) has the same problem :)
I don't know why Microsoft is asking to stay under 40 characters. Technically,
the limit seems to be higher (68 for the target buffer size, as we have seen in
one case -- but this is no official limit).
--
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.
------------------------------------------------------------------------------
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
