On Mon, Jul 13, 2009 at 8:39 PM, emmanuel<goaway1...@gmail.com> wrote: > I have a few questions. > > 1. I created the patch on Linux, without Nautilus, so I'm not certain about > lines 26 and 27 in hggtk/archive.py where the icon and some keys are set. > Does this even apply to archiving?
The two lines set an application icon and our standard keyboard accelerators (ctrl-w, ctrl-q, etc). So they are both applicable. It's ok to reuse the existing icon for the update dialog for now. If we ever added this to the explorer context menu it would need a different icon, but I don't see a need for it there. > 2. Should I add a history for the destination paths? If so, should there be > only one history, one history for directory paths and one for file paths, or > one history for each archive type? I guess the two closest features to archive are patch and bundle creation, and in those cases we don't keep a history. So it's probably fine the way it is. Some people might prefer the archive type to be "sticky" from run to run. I did also just notice that the dialog reads values out of the text entries without converting back from utf8. That will need to be fixed. -- Steve Borho PS: Your patches are showing up doubled. Not sure how that happens. ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
