On Sun, Aug 23, 2009 at 06:14, Adrian Buehlmann<[email protected]> wrote: > On 22.08.2009 19:50, Adrian Buehlmann wrote: >> # HG changeset patch >> # User Adrian Buehlmann <[email protected]> >> # Date 1250963282 -7200 >> # Branch stable >> # Node ID c54c4ab2da9d6fc68eca51c07241dbfa04c2da05 >> # Parent 2e318553be7e491132544e0c4ec9976047423a47 >> shellext: use wide strings for UI texts in ContextMenu.cpp > > Just tested with the current stable Japanese regfile... > > Looks like it works: > http://cdn.bitbucket.org/abuehl/thg-abuehl/downloads/jp-cmenu.png > > (but please don't ask me what those entries mean :) > > At least I figured out how to teach my English Windows XP to take > a menu font that can show Japanese glyphs (I found and choose > "Arial Unicode MS" -- looks ugly, but seems able to show jp chars).
Very thanks, Adrian. The patch works good with Explorer.exe. However, it doesn't work with the application "X-Finder" (integrate with shell extension) that requests ANSI help text. This means "GCS_HELPTEXTW" is OK (Explorer.exe): [2952] [THG] CShellExt::GetCommandString: idCmd = 0, uFlags = 5 (GCS_HELPTEXTW), cchMax = 600 [2952] [THG] CShellExt::GetCommandString: name = "commit" [2952] [THG] CShellExt::GetCommandString: res = 0, pszName (wide) = "変更点をリポジトリにコミットします" but "GCS_HELPTEXTA" is NG (X-Finder): [2300] [THG] CShellExt::GetCommandString: idCmd = 0, uFlags = 1 (GCS_HELPTEXTA), cchMax = 201 [2300] [THG] CShellExt::GetCommandString: name = "commit" [2300] [THG] CShellExt::GetCommandString: res = 0, pszName = "" It shows context menu label correctly, but doesn't show help text, it was empty. I'd like to fix this issue and send as a patch later. > But in debug view I see only question marks: > > [2976] [THG] CShellExt::GetCommandString: name = "vdiff" > [2976] [THG] CShellExt::GetCommandString: res = 0, pszName (wide) = > "????GUI???????????" > > Looks like OutputDebugStringW isn't that powerful on wide strings. I also use English WIndows XP. Please try to change font from DebugView menu: "Edit -> Font...". Otherwise, you need to install "East Asian Language Support" to Windows. But this component may modify your environment, I don't recommend to install. > Hopefully Yuki is a better tester for this... Sure :) And I also test with the application that requests ANSI string. -- Yuki KODAMA ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Tortoisehg-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
