2009/8/28 Jean-Marie Clément <jeanmarieclem...@web.de>:
> nautilus: ignore file: ignore file dialog does not popup (ubuntu 9.04)
>
> Please find fix proposal below.
>
> Description:
> ============
> Running Ubuntu 9.04, mercurial 1.3.1, tortoisehg stable, changeset
> 3740:572eaa9d2262
>
> Found following problem: nothing happens when invoking '(context menu) -
> ignore' on a file from the 'view file status' dialog in nautilus.
> After closing the View File Status dialog, the 'TortoiseHG Bug Report'
> pops up with following content:
>
> {{{
> #!python
> ** Please report this bug to tortoisehg-disc...@lists.sourceforge.net or
> http://bitbucket.org/tortoisehg/stable/issues
> ** Mercurial version (1.3.1). TortoiseHg version (unknown)
> ** Command: status
> ** CWD: /home/jean-marie/Documents/BBS/Admin/classroom_extensions
> ** Extensions loaded: graphlog, extdiff
> Recoverable runtime error (stderr):
> Traceback (most recent call last):
> File
> "/home/jean-marie/Documents/dev/tortoisehg_stable_crisp/hggtk/status.py",
> line 1289, in ignore
> dlg = hgignore.HgIgnoreDialog(self.repo.root, w)
> NameError: global name 'w' is not defined
>
> }}}
>
> Fix proposal:
> =============
>
> Changing the 'w' parameter in 'wfile' fixes the problem:
>
> Change:diff -r 572eaa9d2262 hggtk/status.py
> --- a/hggtk/status.py Thu Aug 27 20:03:29 2009 -0500
> +++ b/hggtk/status.py Fri Aug 28 12:01:55 2009 +0200
> @@ -1286,7 +1286,7 @@
> dlg.set_notify_func(self.ignoremask_updated)
> def ignore(menuitem, files):
> wfile = util.pconvert(files[0])
> - dlg = hgignore.HgIgnoreDialog(self.repo.root, w)
> + dlg = hgignore.HgIgnoreDialog(self.repo.root, wfile)
> dlg.show_all()
> dlg.set_notify_func(self.ignoremask_updated)
>
Thanks, I've applied this fix.
> Hope this helps, and I hope my first submit was ok - I had difficulties
> to find out how to do it properly. If I missed it, please tell.
This was pretty useful, but it is typically easier on everyone
(including yourself) to check in your fix locally, give it a
meaningful commit message explaining what you are fixing, then then
use the email tool (from the synchronize dialog) to send it to this
list.
http://bitbucket.org/tortoisehg/stable/wiki/developers/contributing
Cheers,
--
Steve Borho
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
