On 13.09.2009 01:53, Steve Borho wrote:
> On Sat, Sep 12, 2009 at 4:15 PM, Adrian Buehlmann <adr...@cadifra.com> wrote:
>> I've pushed the experimental cset
>>
>> "history: add syncbar (not yet functional)"
>>
>> as http://bitbucket.org/abuehl/thg-abuehl/changeset/555dbc09aa85/
>>
>> It is not yet functional, just the ui elements.
>>
>> The idea is that we could later put pull, push, etc buttons
>> in the toolbar of history.
>>

BTW, sorry about the typo in the subject. But I won't start a new
thread to fix it.

>> What do you think?
>> Is this the right way to go?
> 
> If we compressed the filter bar features, we could put the two of them
> side-by-side to save vertical space.

I wouldn't put the two side by side.

Sync URL's can be quite long and the user should have a means to make
the url visible. With the vertical layout (sync over filter), the user
can make the window wider to see longer urls.

If we try to put more stuff on the side of the url, it will make this
harder.

I prefer keeping the two bars separate, so they can be enabled
independently.

The filterbar is conceptually different from the syncbar, let's not
merge the two into the same.

I also imagine that users will have the filter in hidden state much
more often than the syncbar.

>> As a side note, I've found that there are sometimes drawing errors
>> (this is on Windows). Hiding/showing the filter or syncbar may
>> produce drawing errors in the log pane. No idea why this is
>> happening.
> 
> This happens during merge as well, the newly underlined 2nd parent row
> is sometimes incompletely drawn.  the changelog treeview seems to find
> to be very good at finding GTK+ refresh bugs.
> 

:(

> I don't know if the hide methodology is making it worse..
> unfortunately I need to go.

Thanks for looking and responding

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to