On Mon, Sep 14, 2009 at 4:02 AM, Adrian Buehlmann <adr...@cadifra.com> wrote:
> # HG changeset patch
> # User Adrian Buehlmann <adr...@cadifra.com>
> # Date 1252918737 -7200
> # Node ID a42ef62ba49cd2136e9e733f665a2d8cfa7e0b83
> # Parent f0be49afe1ab5f979b7a56ddeb20c5dfb32f6eea
> thgtaskbar: add missing signals (fixes db36d1f7e96a)
>
> Fixes traceback written to thgtaskbar.exe.log when opening the "Options..."
> dialog from the context menu of the tray icon:
>
> C:\Program Files\TortoiseHg\library.zip\tortoisehg\hgtk\gtklib.py:48:
> GtkWarning: gtkwidget.c:4247: widget `GtkWindow' has no activatable
> signal "thg-close" without arguments
> ...
Ah, I removed the import of hgtk because it looked like it wasn't
being used. I can fix the problem more cleanly by added the hgtk
import back in, with a comment about why it's needed. Thanks for
looking into this.
> Exception in thread Thread-3:
> Traceback (most recent call last):
> File "threading.pyo", line 486, in __bootstrap_inner
> File "threading.pyo", line 446, in run
> File "thgtaskbar.py", line 175, in launch
> File "tortoisehg\hgtk\taskbarui.pyo", line 26, in __init__
> File "tortoisehg\hgtk\gtklib.pyo", line 60, in set_tortoise_keys
> TypeError: <TaskBarUI object at 0x1332be8 (GtkWindow at 0x198f008)>:
> unknown signal name: thg-close
>
> (as reported by Yuki on Tortoisehg-develop)
>
> diff --git a/thgtaskbar.py b/thgtaskbar.py
> --- a/thgtaskbar.py
> +++ b/thgtaskbar.py
> @@ -8,6 +8,8 @@ import time
> import threading
> import cStringIO
> import Queue
> +import gtk
> +import gobject
>
> from win32api import *
> from win32gui import *
> @@ -37,6 +39,11 @@ if hasattr(sys, "frozen"):
>
> APP_TITLE = _('TortoiseHg RPC server')
>
> +# Add TortoiseHg signals, hooked to key accelerators in gtklib
> +for sig in ('thg-exit', 'thg-close', 'thg-refresh', 'thg-accept'):
> + gobject.signal_new(sig, gtk.Window,
> + gobject.SIGNAL_ACTION, gobject.TYPE_NONE, ())
> +
> SHOWLOG_CMD = 1023
> EXIT_CMD = 1025
>
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Tortoisehg-develop mailing list
> Tortoisehg-develop@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
>
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
