On Thu, Sep 17, 2009 at 6:25 AM, Yuki KODAMA <endflow....@gmail.com> wrote:
> On Thu, Sep 17, 2009 at 20:15, Yuki KODAMA <endflow....@gmail.com> wrote:
>> On Thu, Sep 17, 2009 at 19:38, Sune Foldager <sune.folda...@me.com> wrote:
>>>>> # HG changeset patch
>>>>> # User Yuki KODAMA <endflow....@gmail.com>
>>>>> # Date 1253157443 -32400
>>>>> # Node ID 4aa1f505e81b317d2d2602cf60665a2780d5d1d2
>>>>> # Parent  4a036396464acbfe611273642448ea9126faedcf
>>>>> update: improve UI layout
>>>
>>>>I tried that, looks better now. Thanks!
>>>
>>> What looks better?
>>>
>>> /Sune
>>
>> It does nothing, no layout changing and no improving.
>> However, it cleanups the code related UI.
>> In that sense, it's "cleanup UI code", not "improve UI layout".
>>
>> The reason why I do this cleanup are:
>> *gtk.Dialog has keyboard accelerators in default
>> *gtk.Dialog has the area for typical buttons (Close, Cancel, ...) in default
>> *gtk.Dialog has the area for contents in default
>>
>> This means we can reduce the code. If we use gtk.Window, we have to write
>> some code to introduce above features.
>
> Forgot to say, now I'm trying embedding CmdWidget component into
> Update dialog.  To update to the revision from Changelog viewer,
> it opens 2 windows: UpdateDialog, CmdDialog.
> I think it's a bit ridiculous and verbosely...

I'm glad you've started on this work.  I look forward to it.

On a side node, I think our update dialog should add --check to the
update command arguments if the --clean checkbox is not checked.  The
user is explicitly selecting the revision to update to, and thus they
are aware of any branch hopping that might be necessary.

--
Steve Borho

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to