Hi folks,

I have a small (but a bit annoying) problem related window focus.
In Changelog viewer, I open Update dialog from context menu
of changeset TreeView.  After finished the update, I sometimes want
to close Changelog viewer with CTRL-W keyboard shortcut, but, for this,
I always have to click Changelog viewer before hitting CTRL-W so that
Changelog viewer could be grab the focus.

IMO, this problem are caused by "dialog.set_transient_for(None)"
statement. For example:

    def checkout(self, menuitem):
        rev = self.currevid
        parents = [x.node() for x in self.repo.parents()]
        dialog = update.UpdateDialog(rev)
        dialog.set_transient_for(self)
        dialog.show_all()
        dialog.set_notify_func(self.checkout_completed, parents)
        dialog.present()
        dialog.set_transient_for(None)  # <- YOU ARE!

By dropping this statement, I could close Changelog viewer directly,
but I noticed that the statement is just workaround and based on
historical reason; see <f668034aeda3>.

commit log of <f668034aeda3>:

    hggtk/history: workaround strange bug on transient dialogs

    where we must remove transient explicitly to prevent history dialog
    from getting pushed behind other app windows

I couldn't reproduced this issue in my environment (WinXP),
I don't know whether the issue is still alive now.

If now we drop "set_transient_for(None)", it works without problems,
I want to cleanup these statements.

Waiting for comments, thanks in advance.

-- 
Yuki KODAMA

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to