On Wed, Sep 30, 2009 at 10:11 AM, Steve Borho <st...@borho.org> wrote:
>
>
> On Wed, Sep 30, 2009 at 9:53 AM, Peer Sommerlund <
> peer.sommerl...@gmail.com> wrote:
>
>> If I start hgtk log and enter "*.py" into file patterns for the thg repo,
>> I get the following.
>>
>> thg cset 2d24479142bf
>> branch default
>> date 29-Sep-2009
>>
>> {{{
>> #!python
>> ** Please report this bug to
>> http://bitbucket.org/tortoisehg/stable/issues or
>> tortoisehg-disc...@lists.sourceforge.net
>> ** Mercurial version (1.3.1). TortoiseHg version (unknown)
>> ** Command: log
>> ** CWD: E:\src\mercurial\thg\branch-view
>> ** Extensions loaded: mq, convert, patchbomb, pbranch
>> Recoverable runtime error (stderr):
>> Traceback (most recent call last):
>> File
>> "E:\src\mercurial\thg\branch-view\tortoisehg\hgtk\logview\treeview.py", line
>> 213, in populate
>> (rev, node, lines, wfile) = self.grapher.next()
>> File
>> "E:\src\mercurial\thg\branch-view\tortoisehg\hgtk\logview\revgraph.py", line
>> 503, in filtered_log_generator
>> changeiter, matchfn = cmdutil.walkchangerevs(repo.ui, repo, pats, get,
>> opts)
>> File "c:\Python25\Lib\site-packages\mercurial\cmdutil.py", line 1123, in
>> walkchangerevs
>> for rev, changefiles in changerevgen():
>> File "c:\Python25\Lib\site-packages\mercurial\cmdutil.py", line 1121, in
>> changerevgen
>> yield j, change(j)[3]
>> File "c:\Python25\Lib\site-packages\mercurial\context.py", line 84, in
>> __getitem__
>> return self.filectx(key)
>> File "c:\Python25\Lib\site-packages\mercurial\context.py", line 159, in
>> filectx
>> fileid = self.filenode(path)
>> File "c:\Python25\Lib\site-packages\mercurial\context.py", line 148, in
>> filenode
>> return self._fileinfo(path)[0]
>> File "c:\Python25\Lib\site-packages\mercurial\context.py", line 143, in
>> _fileinfo
>> _('not found in manifest'))
>> mercurial.error.LookupError: 3...@69de4bfd5ab2: not found in manifest
>>
>> }}}
>>
>
> I haven't figured out how or where the change occurred, but the
> walkchangerevs() API seems to have changed on the stable branch between 1.3
> and the tip of hg-stable. If you update your mercurial install to tip of
> hg-stable or tip of hg-main, it should work ok.
>
> It was changeset dc490020e614 in our repo which "fixed" our inputs to work
> with the tip of hg-stable. It would be nice for us to work in either hg-1.3
> or tip of hg-1.3 stable, but I wasn't able to determine how or where the
> change occurred. And was quite annoyed something like that was done on the
> stable branch.
>
I've done some more investigations into this today and am more confused than
before. The change made by changeset dc490020e614 breaks our support for
hg-1.3.1, but fixes support for tip of hg-main and also works on tip of
hg-stable.
That is an odd combination, to say the least. To summarize:
Before changeset dc490020e614:
* hg-1.3, hg-1.3.1, and hg-stable tip all work
* hg-main is broken (AttributeError, below)
After changeset dc490020e614:
* hg-stable tip and hg-main tip work
* hg-1.3, hg-1.3.1 are broken (LookupError, above)
{{{
File
"/home/steve/tools/tortoisehg-dev/tortoisehg/hgtk/logview/treeview.py", line
196, in populate
(rev, node, lines, parents) = self.grapher.next()
File
"/home/steve/tools/tortoisehg-dev/tortoisehg/hgtk/logview/revgraph.py", line
421, in filtered_log_generator
changeiter, matchfn = cmdutil.walkchangerevs(repo.ui, repo, pats, get,
opts)
File "/home/steve/lib/python/mercurial/cmdutil.py", line 1124, in
walkchangerevs
matches = filter(m, ctx.files())
AttributeError: 'tuple' object has no attribute 'files'
}}}
--
Steve Borho
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
