On Tue, Oct 20, 2009 at 10:53, Steve Borho <st...@borho.org> wrote: > On Mon, Oct 19, 2009 at 8:49 PM, Yuki KODAMA <endflow....@gmail.com> wrote: >> On Tue, Oct 20, 2009 at 10:24, Yuki KODAMA <endflow....@gmail.com> wrote: >>> On Tue, Oct 20, 2009 at 08:21, Steve Borho <st...@borho.org> wrote: >>>> On Mon, Oct 19, 2009 at 5:47 PM, Adrian Buehlmann <adr...@cadifra.com> >>>> wrote: >>>>> There seem to be some problems with caching csinfo.py does together with >>>>> for example when transitioning from bundle applied to accept. >>>>> >>>>> I said 'incoming', selected some csets from bundle, then accepted, reset >>>>> marks, >>>>> selected csets again... >>>> >>>> If csinfo is generating or holding onto a repo object, it needs to be >>>> refreshed at the same time the bundle is removed from history's >>>> self.repo. >>> >>> Thanks, I'll try to fix this and implement 'clear cache' feature. >>> >>> There are 2 kind of cache problems in csinfo.py. >>> One is holding a reference of 'self.repo' in csinfo and the other is cached >>> changeset data. The former was pointed by Adrian. I found the latter >>> yesterday when I did qfinish command from MQ pane. >>> >>> -- >>> Yuki KODAMA >>> >> >> I figured out more one issue in csinfo. >> After incoming (sync bar) on changelog viewer, csinfo doesn't show changeset >> summary in bundle files. > > Same issue, it needs to take the repo object from the history browser, > just like we give one to the changeset browser and graph viewer (line > 1215) and then remove it afterward (line 1119).
Yep, before fixing csinfo issues, we need to do small refacotring on changeset.py. changeset must be have "set_repo()" method instead of direct assignment to "repo" attribute, just like "graphview.set_repo()". -- Yuki KODAMA ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
