On Tue, Oct 20, 2009 at 11:05 AM, Steve Borho <st...@borho.org> wrote: > On Tue, Oct 20, 2009 at 4:49 AM, Yuki KODAMA <endflow....@gmail.com> wrote: >> On Tue, Oct 20, 2009 at 18:19, Adrian Buehlmann <adr...@cadifra.com> wrote: >>> On 20.10.2009 10:45, Yuki KODAMA wrote: >>>> On Tue, Oct 20, 2009 at 17:06, Adrian Buehlmann <adr...@cadifra.com> wrote: >>>>> # HG changeset patch >>>>> # User Adrian Buehlmann <adr...@cadifra.com> >>>>> # Date 1256025912 -7200 >>>>> # Branch stable >>>>> # Node ID a54a90a04d7fde4bc046802fc295c449d989d8ca >>>>> # Parent c863fe825679aa1fce265065ac675a147cff000a >>>>> csinfo: collapse expander by default >>>>> >>>>> diff --git a/tortoisehg/hgtk/csinfo.py b/tortoisehg/hgtk/csinfo.py >>>>> --- a/tortoisehg/hgtk/csinfo.py >>>>> +++ b/tortoisehg/hgtk/csinfo.py >>>>> @@ -398,7 +398,6 @@ class SummaryPanel(SummaryBase, gtk.Fram >>>>> self.csstyle = style >>>>> >>>>> self.expander = gtk.Expander() >>>>> - self.expander.set_expanded(True) >>>>> self.add(self.expander) >>>>> >>>>> # layout table for contents >>>> >>>> Why collapse the expander in default? >>>> I can't understand why it's needed. >>>> >>> >>> I prefer it to have it collapsed by default, at least in >>> the history viewer. >>> >>> The information in the csinfo is additional detail that >>> I most of the time do not want nor do need to see. >>> So I prefer not to take it up screen space (scrolled or >>> not) by default in the changeset info of the history >>> viewer. >>> >>> Even if it is scrolled but expanded by default, I still >>> have to scroll down more to see more of the diffs. >>> >>> So I think (as I already wrote yesterday) it makes a >>> lot of sense to have it collapsed by default, like >>> Firefox does it with the message pane (see the link >>> to the screenshot I posted yesterday). >> >> That makes sense. I also want to see diff. >> But it's a bit overkill I think. >> >>> However, I would be fine if the expanded state for >>> the csinfo in the log viewer would be stored in the >>> persisted settings for the log viewer (and restored on >>> startup of the log viewer). >> >> Good Idea. >> For the least surprise, I prefer to keep expanded csinfo header by default. >> Since the state of expander will be stored in persisted settings, >> the users who prefer collapsed csinfo can customize changelog viewer. >> >> BTW, now I'm woking on csinfo, to resolve 'cache problems'. >> It will be done in tonight (JST timezone, GMT+9). >> >>> Like that, *this* default would be probably mostly >>> irrelevant then. > > I lean towards removing the expander since it makes other dialogs > (strip, for instance) look quite strange.
I just now read your other submitted change to disable it by default. So.. hmm. Not sure what I think. -- Steve Borho ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
