On Sun, Oct 25, 2009 at 1:56 PM, Sune Foldager <sune.folda...@me.com> wrote: > Steve Borho wrote: >> >> The reason -R implies no fork is that hgtk must chdir() into the >> repository root when it runs (all the dialogs assume they are running >> inside the current repository). If a user tries to launch hgtk from a >> relative path, hgtk will not be able to fork safely after the chdir. >> > > Ok... why is that (that it can't fork safely)? > > I invoke hgtk from a program with all paths absolutized (except hgtk itself, > which is just in the PATH). So maybe it would work for me? What could I do > otherwise, if the --fork option is not a good idea in general (apart from > keeping it in my own patch queue)?
I've pushed your patch, but here's an example of how -R can break forking. hgtk -R path/to/myrepo log hgtk does a chdir to myrepo, then tries to launch (essentially): hgtk --nofork -R path/to/myrepo log and you get a repo not found error. If someone spent a half hour to figure out how to delay the chdir() until after the forking decision, the problem would likely go away. -- Steve Borho ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
