On Thu, Nov 5, 2009 at 7:12 PM, Yuki KODAMA <[email protected]> wrote:
> On Fri, Nov 6, 2009 at 05:47, Wagner Bruna <[email protected]> wrote:
>> # HG changeset patch
>> # User Wagner Bruna <[email protected]>
>> # Date 1257453947 7200
>> # Branch stable
>> # Node ID 7bb78ecb1b11b5bda64a6d5afa4836025967b55b
>> # Parent  9e0c3990c08af0d84cd642cd35f4056db5d9fb7f
>> history: catch LookupError from ambiguous revisions
>>
>> diff --git a/tortoisehg/hgtk/gorev.py b/tortoisehg/hgtk/gorev.py
>> --- a/tortoisehg/hgtk/gorev.py
>> +++ b/tortoisehg/hgtk/gorev.py
>> @@ -54,6 +54,10 @@
>>                 self.gotofunc(revision)
>>             self.revEntry.set_text('')
>>             self.hide()
>> +        except mercurial.error.LookupError, e:
>> +            gdialog.Prompt(_('Ambiguous Revision'), str(e), self).run()
>> +            self.revEntry.grab_focus()
>> +            return
>>         except mercurial.error.RepoError, e:
>>             gdialog.Prompt(_('Invalid Revision'), str(e), self).run()
>>             self.revEntry.grab_focus()
>
> Using 'hglib.LookupError' instead of 'mercurial.error.LookupError' is
> more better.
> Likewise, 'mercurial.error.RepoError' is replaced with 'hglib.RepoError'.

After 1.4 is released, we could remove all those errors from hglib,
since they were only there to hide the fact they were moved around
between 1.1 and 1.3.

Does anyone have any problems with the new string this introduces?

--
Steve Borho

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Tortoisehg-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to